Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add authentication #7

Merged
merged 7 commits into from May 11, 2023
Merged

feat: add authentication #7

merged 7 commits into from May 11, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented May 8, 2023

Adds authentication and checks against keycloak.

@olevski olevski requested a review from a team as a code owner May 8, 2023 23:54
@coveralls
Copy link

coveralls commented May 8, 2023 •
edited

Pull Request Test Coverage Report for Build 4945294250

  • 64 of 71 (90.14%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 88.823%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/renku_crac/auth.py 4 6 66.67%
src/db/adapter.py 58 63 92.06%
Totals Coverage Status
Change from base Build 4937992855: 1.6%
Covered Lines: 1041
Relevant Lines: 1172
💛 - Coveralls

@olevski olevski mentioned this pull request May 9, 2023
Merged
Panaetius
Panaetius requested changes May 9, 2023
View reviewed changes
src/db/adapter.py Outdated Show resolved Hide resolved
src/db/adapter.py Outdated Show resolved Hide resolved
src/db/adapter.py Outdated Show resolved Hide resolved
src/renku_crac/app.py Outdated Show resolved Hide resolved
src/renku_crac/app.py Outdated Show resolved Hide resolved
src/renku_crac/auth.py Outdated Show resolved Hide resolved
src/renku_crac/config.py Outdated Show resolved Hide resolved
src/users/dummy.py Outdated Show resolved Hide resolved
@olevski olevski requested a review from Panaetius May 10, 2023 13:20
@olevski
Copy link
Member Author

olevski commented May 10, 2023

@Panaetius this is ready now.

@olevski olevski mentioned this pull request May 10, 2023
Merged
Panaetius
Panaetius requested changes May 11, 2023
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change, otherwise it looks great now 👍

src/db/adapter.py Outdated Show resolved Hide resolved
@olevski olevski requested a review from Panaetius May 11, 2023 07:44
@olevski olevski merged commit 81298a1 into main May 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olevski @coveralls @Panaetius