Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix rclone schema and add support for validating storage connections #92

Merged
merged 10 commits into from Nov 27, 2023

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Nov 20, 2023

examples wasn't returned.

updates apispec
adds check to ensure apispec is up to date
adds testing of connections using rclone
fixes bug in apispec with nullable values for patch endpoint

@Panaetius Panaetius requested a review from a team as a code owner November 20, 2023 09:06
@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6972056243

  • 44 of 45 (97.78%) changed or added relevant lines in 5 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.9%) to 91.656%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/storage/rclone.py 16 17 94.12%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/blueprints.py 1 94.41%
components/renku_data_services/storage/rclone.py 5 90.59%
Totals Coverage Status
Change from base Build 6957451206: 0.9%
Covered Lines: 2889
Relevant Lines: 3152

💛 - Coveralls

@Panaetius Panaetius force-pushed the fix-rclone-schema-endpoint branch 3 times, most recently from b72bdcc to 79a39d8 Compare November 21, 2023 13:35
@Panaetius Panaetius force-pushed the fix-rclone-schema-endpoint branch 3 times, most recently from 12edfb0 to af123ac Compare November 21, 2023 16:01
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Panaetius I am not sure if this changed in this PR or not. But the generated code for the storage apispec does not match the current apispec yaml file. I.e. if I run make schemas then I get changes in the generated python code for the storage apispec.

@Panaetius
Copy link
Member Author

@Panaetius I am not sure if this changed in this PR or not. But the generated code for the storage apispec does not match the current apispec yaml file. I.e. if I run make schemas then I get changes in the generated python code for the storage apispec.

for some reason I thought that CI creates those. I've updated them now

@olevski
Copy link
Member

olevski commented Nov 23, 2023

@Panaetius thanks for making the update. But the tests are failing now. Some endpoint is responding with a 422 whereas a 200 is expected. I think this is because of the apispec.py update.

And yeah we dont have a CI action that updates the code generated from the apispec.yaml file. We can add one that generates the code or one that simply checks that the generated code and the stuff in the yaml file match.

@Panaetius
Copy link
Member Author

Panaetius commented Nov 23, 2023

it was due to a change rok made a while ago that broke things, but we never updater the apispec.py file so it didn't have any effect. Would be nice to have a test that that is up to date in CI. bit annoying since it also updates the date line so needs more than a simple diff

@Panaetius Panaetius force-pushed the fix-rclone-schema-endpoint branch 4 times, most recently from 71905ed to 12891d0 Compare November 23, 2023 14:21
@Panaetius
Copy link
Member Author

@olevski I've added a test to ensure the schema is updated

@olevski olevski self-requested a review November 23, 2023 14:57
olevski
olevski previously approved these changes Nov 23, 2023
@Panaetius Panaetius changed the title fix rclone schema examples values fix rclone schema and add support for validating storage connections Nov 23, 2023
@Panaetius Panaetius changed the title fix rclone schema and add support for validating storage connections feat: fix rclone schema and add support for validating storage connections Nov 23, 2023
@Panaetius Panaetius merged commit b7ca878 into main Nov 27, 2023
8 checks passed
@Panaetius Panaetius deleted the fix-rclone-schema-endpoint branch November 27, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants