Skip to content

Commit

Permalink
squashme: apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
  • Loading branch information
olevski and Panaetius committed Apr 16, 2024
1 parent 2e77d77 commit 2477c9f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/revproxy/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ func (a *Auth) Middleware() echo.MiddlewareFunc {
}

var notebooksGitlabAccessTokenHandler TokenHandler = func(c echo.Context, accessToken models.OauthToken) error {
// NOTE: As long as the token comes from the database we can trust it and do nto have to validate it.
// Each service that the request ultimately goes to will also validate before it users the token
// NOTE: As long as the token comes from the database we can trust it and do not have to validate it.
// Each service that the request ultimately goes to will also validate before it uses the token
type gitCredentials struct {
Provider string `json:"provider"`
AuthorizationHeader string
Expand Down

0 comments on commit 2477c9f

Please sign in to comment.