-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ontology definition #161
Conversation
a0ba072
to
79578bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working for me at the moment. As soon as I switch from dcterms
to schema
, I always get no result from the sparql query. Should I update something else at the same time (changes needed on the graph-service as well?)
Right, I suppose there should be an |
ok, that should be fixed in |
you mean the renku-python version? Yes - but I think for now we can just check for both predicates. |
79578bb
to
faca93b
Compare
can you try again? I just pushed a change that should make it work with the old ontology as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it works.
Do we keep both predicates only for a short time because we will re-index all the projects or is this staying for the long term?
Presumably for a short time. This will happen frequently over the next weeks as we converge on a graph that we like unfortunately... |
Using
dcterms
is no longer necessary and we are usingschema.org
instead - therefore the graph query needs to be modified.