Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Project Update API to wait for call to the Core #1695

Merged
merged 4 commits into from Sep 6, 2023

Conversation

jachro
Copy link
Contributor

@jachro jachro commented Sep 5, 2023

This PR modifies the Project Update API in a way that the call to update project metadata in the Core is not done asynchronously but synchronously. With the change, eventual problems on the Core side will be reported to the caller.

Another change regards projects with protected branches that Core cannot push to. In such cases, Project Update API returns Conflict 409 status and updates only GL and TS but only with values that don't have to be passed to the Core. The values that need calling the Core are pushed by the Core to a new branch about the user is informed and for which the user needs to create a PR and merge it. An example response in this case will be:

{
  "message": {
    "details": "Only visibility=public got updated in the TS due to branch protection rules on the default branch 'main'. However, an update commit was pushed to a new branch 'main/344422' which has to be merged to the default branch with a PR",
    "branch": "main/344422"
  }
}

@jachro jachro requested a review from a team as a code owner September 5, 2023 13:20
@jachro jachro merged commit f27e857 into development Sep 6, 2023
13 checks passed
@jachro jachro deleted the project-update-api-wait-for-core branch September 6, 2023 14:07
@jachro jachro mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants