oneliner patching for packagecloud.io trust issue #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokroskar
requested changes
Mar 1, 2019
docker/base/Dockerfile
Outdated
| @@ -47,6 +47,7 @@ RUN apt-get update && apt-get install -yq --no-install-recommends \ | |||
| RUN ln -s /usr/lib/x86_64-linux-musl/libc.so /lib/libc.musl-x86_64.so.1 | |||
|
|
|||
| # install git-lfs | |||
| RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 6B05F25D762E3157 | |||
There was a problem hiding this comment.
can you combine this with the line below into a single RUN?
There was a problem hiding this comment.
done.
@rokroskar: note that git-lfs is now in the 2.7.x range, should we update that, too?
There was a problem hiding this comment.
@rokroskar : so, let's switch to 2.7.1, no?
…derstood the problem! ®
jirikuncar
reviewed
Mar 4, 2019
jirikuncar
reviewed
Mar 4, 2019
|
@fgeorgatos I still don't understand which problem this addresses. For example, I can do: Note that |
Co-Authored-By: fgeorgatos <kefalonia@gmail.com>
Co-Authored-By: fgeorgatos <kefalonia@gmail.com>
|
I can't reproduce this -- keeping the PR open in case it comes back and we can do a minor release. |
|
Using We have the error in images based on 0.3.2 and earlier, but not in latest. Recommendation is to update the project to use the new images. The risk is that it may go against reproducibility. You can verify this with the Dockerfile using different combinations of WORKS:Log shows that it is using the updated public key from packagecloud.io, FAILS:Log shows that it is using the older public key from packagecloud.io, |
|
What you can do is
Or
Note that when you make a new tag and push it, the images should be built by Travis automatically. |
|
@rokroskar : I understand the motivation of the maintenance release on |
|
@fgeorgatos note that there's no need to change the dockerfile to fix this, but the base image needs to be rebuilt to use updated apt. Also, if you want to install git-lfs differently, please propose a change! |
|
I'm closing this for now - please reopen if it becomes an issue again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erbou : do you think this patch makes sense?
This is what it fixes: https://renkulab.io/gitlab/damien.bouffard/datalakes/issues/26