Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git error codes to notebooks response #1055

Merged
merged 3 commits into from
May 18, 2022

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented May 10, 2022

closes #1037

/deploy #persist

@Panaetius Panaetius requested a review from a team as a code owner May 10, 2022 12:08
@olevski olevski temporarily deployed to renku-ci-nb-1055 May 17, 2022 06:58 Inactive
@olevski
Copy link
Member

olevski commented May 17, 2022

@Panaetius this looks good to me. I just want to see that the message will really show up when you try to clone but run out of space. If it does not show up this is not really the fault of this PR though. But still it would be nice to double-check.

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1055.dev.renku.ch

@olevski olevski temporarily deployed to renku-ci-nb-1055 May 17, 2022 07:23 Inactive
@olevski
Copy link
Member

olevski commented May 17, 2022

@Panaetius as I suspected there were some issues in the code that are not part of this PR and were there from before that were preventing the error messages from properly surfacing.

I corrected these and I will submit a 2nd PR that will make the necessary changes into this branch. Then we can merge my changes into your branch and merge this branch into master.

Or I can directly commit these changes into your feature branch? If you prefer this let me know and I will close my PR and commit directly here.

@olevski olevski deployed to renku-ci-nb-1055 May 17, 2022 21:42 Active
@Panaetius Panaetius merged commit dd59afe into master May 18, 2022
@Panaetius Panaetius deleted the feature/git-clone-exit-codes branch May 18, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync exit codes from git-clone with notebooks api
3 participants