Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept zero as max_lines parameter for logs #1336

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

olevski
Copy link
Member

@olevski olevski commented Nov 25, 2022

/deploy #persist

@olevski olevski requested a review from a team as a code owner November 25, 2022 10:01
@olevski olevski temporarily deployed to renku-ci-nb-1336 November 25, 2022 10:02 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1336.dev.renku.ch

@ciyer
Copy link
Contributor

ciyer commented Nov 25, 2022

This change makes sense, but it does't fix the problem that we were having. The backend still responds with this error when we try to make a query with max_lines=0:

{"error": {"code": 1422, "message": "The request was well-formed but was unable to be followed due to semantic errors.", "detail": null}}

@olevski olevski temporarily deployed to renku-ci-nb-1336 November 25, 2022 13:00 Inactive
@olevski
Copy link
Member Author

olevski commented Nov 25, 2022

This change makes sense, but it does't fix the problem that we were having. The backend still responds with this error when we try to make a query with max_lines=0:

{"error": {"code": 1422, "message": "The request was well-formed but was unable to be followed due to semantic errors.", "detail": null}}

@ciyer there were actually 2 places where this needs to be changed. The first one I chaged is only for documentation purposes in the swagger page. Now it should truly work.

@ciyer
Copy link
Contributor

ciyer commented Nov 25, 2022

Yes, this fixes the problem, thanks!

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olevski olevski deployed to renku-ci-nb-1336 November 28, 2022 14:21 Active
@olevski olevski merged commit d18aba9 into master Nov 29, 2022
@olevski olevski deleted the fix-logs-maxlines-parameter branch November 29, 2022 12:21
@olevski olevski restored the fix-logs-maxlines-parameter branch November 30, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants