-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): use PV to hibernate/resume sessions #1518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
June 21, 2023 00:31
— with
GitHub Actions
Inactive
You can access the deployment of this PR at https://renku-ci-nb-1518.dev.renku.ch |
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
June 26, 2023 23:16
— with
GitHub Actions
Error
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
June 26, 2023 23:16
— with
GitHub Actions
Failure
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
June 27, 2023 00:44
— with
GitHub Actions
Failure
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
June 27, 2023 05:01
cf31405
to
f1a670a
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
June 27, 2023 05:01
— with
GitHub Actions
Failure
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
June 27, 2023 14:59
— with
GitHub Actions
Inactive
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 3, 2023 23:02
f1a670a
to
632c9ff
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 3, 2023 23:02
— with
GitHub Actions
Error
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 3, 2023 23:16
632c9ff
to
a0394b6
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 3, 2023 23:16
— with
GitHub Actions
Failure
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
July 5, 2023 10:05
— with
GitHub Actions
Inactive
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 17, 2023 07:09
a0394b6
to
f0c7230
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 17, 2023 07:09
— with
GitHub Actions
Failure
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 21, 2023 10:11
— with
GitHub Actions
Failure
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 21, 2023 10:16
f0c7230
to
63b4b63
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 21, 2023 10:16
— with
GitHub Actions
Failure
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 21, 2023 13:40
63b4b63
to
7832869
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 21, 2023 13:40
— with
GitHub Actions
Failure
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 21, 2023 18:53
7832869
to
fb64073
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 21, 2023 18:53
— with
GitHub Actions
Error
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
July 21, 2023 19:03
fb64073
to
959c4c9
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 21, 2023 19:03
— with
GitHub Actions
Error
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
July 21, 2023 19:15
— with
GitHub Actions
Error
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
July 21, 2023 19:18
— with
GitHub Actions
Inactive
Seems this cause the service to crash on startup
leafty
temporarily deployed
to
renku-ci-nb-1518
August 29, 2023 08:07
— with
GitHub Actions
Inactive
m-alisafaee
force-pushed
the
pitch/session-persistence
branch
from
August 29, 2023 09:22
5519f56
to
d1bfc69
Compare
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
August 29, 2023 09:22
— with
GitHub Actions
Error
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
August 29, 2023 09:24
— with
GitHub Actions
Inactive
olevski
previously approved these changes
Aug 29, 2023
leafty
reviewed
Aug 29, 2023
leafty
requested changes
Aug 31, 2023
m-alisafaee
changed the title
feat(app): use pv to persist sessions
feat(app): use PV to hibernate/resume sessions
Aug 31, 2023
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
August 31, 2023 14:54
— with
GitHub Actions
Inactive
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
September 5, 2023 14:39
— with
GitHub Actions
Inactive
* feat(app): use amalthea 0.9.1
m-alisafaee
temporarily deployed
to
renku-ci-nb-1518
September 8, 2023 08:15
— with
GitHub Actions
Inactive
olevski
approved these changes
Sep 8, 2023
m-alisafaee
had a problem deploying
to
renku-ci-nb-1518
September 11, 2023 08:28
— with
GitHub Actions
Error
olevski
temporarily deployed
to
renku-ci-nb-1518
September 11, 2023 08:29
— with
GitHub Actions
Inactive
leafty
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
/notebooks/servers/<server_name>
endpoint withPATCH
method that accepts astate
argument. Settingstate
tohibernated
makes the server to go to hibernation and settingstate
torunning
resumes a hibernated server.When hibernating a server:
spec.jupyterServer.hibernated
is set toTrue
in the server's manifest file.spec.jupyterServer.hibernated
set to true, Amalthea scales server's statefulset to have 0 replicas and set's server'sstate
to hibernated.When resuming:
spec.jupyterServer.hibernated
is set toFalse
in the server's manifest file.spec.jupyterServer.hibernated
set to false, Amalthea scales server's statefulset to have 1 replica.It also adds a
renku.io/hibernatedSecondsThreshold
annotation to the server that shows when a hibernated sessions will be deleted.Related: SwissDataScienceCenter/amalthea#344
/deploy #persist extra-values=notebooks.userSessionPersistentVolumes.enabled=true,notebooks.amalthea.image.repository=renku/amalthea,notebooks.amalthea.image.tag=db70f80ef1983d49a1b167faa57d02d9d8b9554f renku-ui=leafty/2526-feature-persistent-sessions