-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use shortened commit-sha to check for an autosave match #190
fix: use shortened commit-sha to check for an autosave match #190
Conversation
@rokroskar and @lorenzo-cavazzi please test this to see if you it resolves your issue. It worked for me. |
It's testable in the UI form here: https://lorenzotest.dev.renku.ch |
Did you test with this latest commit: 2720d1f? |
right, let me update the preview and test it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine for me now! And I absolutely love this feature!
If anyone else what to try the feature from the UI, I updated the preview here: https://lorenzotest.dev.renku.ch/
Please don't merge this until we agree upon the final solution in #187. |
@mohammad-sdsc if this meets the requirements we came up with last Friday, could we merge it? |
Done! |
Closes #187 |
Fixes a bug in check for autosaved branch commit-sha where it was checking against the long commit-sha instead of the short one.