Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook spawn requires maintainer permissions #210

Closed
rokroskar opened this issue Sep 10, 2019 · 0 comments · Fixed by #212
Closed

notebook spawn requires maintainer permissions #210

rokroskar opened this issue Sep 10, 2019 · 0 comments · Fixed by #212
Assignees
Labels
bug Something isn't working good first issue

Comments

@rokroskar
Copy link
Member

Because we try to check the project's environment variables in the spawner code, the developer permissions are no longer enough to launch a notebook.

The line in question is

variable.key: variable.value for variable in gl_project.variables.list()

We should either fail gracefully here on a 403 or remove this - to my knowledge it is not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue
Projects
None yet
2 participants