Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extraEnv requires only string values now #511

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

olevski
Copy link
Member

@olevski olevski commented Jan 15, 2021

So I saw the helm lint failed after the latest changes. But the line that causes the failure has not been changed in months.

I think this is occurring because jupyterhub was upgraded.

This is the line in the jupyterhub helm chart _helpers.tpl that causes this problem:

{{- else if eq (typeOf $value) "string" -}}
- name: {{ $key | quote }}
  value: {{ $value | quote | println }}
{{- else }}
{{- printf "?.extraEnv.%s had an unexpected type (%s)" $key (typeOf $value) | fail }}
{{- end }}

It seems that before non-string values were allowed in the extraEnv part, but not anymore. The lint command passes after this.

@olevski olevski requested a review from a team as a code owner January 15, 2021 09:42
Copy link
Contributor

@pameladelgado pameladelgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@olevski olevski merged commit 2a1bb10 into master Jan 15, 2021
@olevski olevski deleted the fix-helm-chart-extra-env-lint-fail branch January 15, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants