fix: extraEnv requires only string values now #511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I saw the
helm lint
failed after the latest changes. But the line that causes the failure has not been changed in months.I think this is occurring because jupyterhub was upgraded.
This is the line in the jupyterhub helm chart _helpers.tpl that causes this problem:
It seems that before non-string values were allowed in the extraEnv part, but not anymore. The lint command passes after this.