-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): keep git-proxy alive on session shutdown #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
force-pushed
the
use-tini-in-sidecars
branch
from
February 24, 2022 20:38
27010e6
to
0f4c13b
Compare
You can access the deployment of this PR at https://renku-ci-nb-951.dev.renku.ch |
olevski
force-pushed
the
use-tini-in-sidecars
branch
from
March 14, 2022 17:20
191ca3f
to
1f2ffe3
Compare
olevski
force-pushed
the
use-tini-in-sidecars
branch
from
April 6, 2022 00:12
68337bc
to
32f8dc6
Compare
olevski
force-pushed
the
use-tini-in-sidecars
branch
from
April 6, 2022 00:37
32f8dc6
to
5a68c4d
Compare
olevski
force-pushed
the
use-tini-in-sidecars
branch
from
April 6, 2022 09:29
05b8cfe
to
18c6293
Compare
vigsterkr
previously approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Viktor Gal <vigsterkr@gmail.com>
vigsterkr
previously approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that in many cases the autosave branch does not get created. This was especially true if the unsaved commits in the session has large data files.
The main reason for this is that k8s waits only 30 seconds after it has sent the termination signal (SIGTERM) to a pod before it forcefully shuts it down. So if the autosave takes more than 30 seconds to be created then it will be interrupted before it is fully pushed/created.
K8s has the
terminationGracePeriodSeconds
for this purpose. But for this to work properly all containers have to properly handle the initial SIGTERM signal that k8s sent. If not then the pod will always taketerminationGracePeriodSeconds
to shutdown.By adding
tini
to containers now the SIGTERM signal is properly handled. But now the containers shut down so quickly that the autosave branch still cannot be created.This is solved by the following:
closes #920