feat(app): switch git proxy to golang #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
force-pushed
the
replace-git-proxy
branch
6 times, most recently
from
9d51b9b
to
d93c288
Compare
olevski
force-pushed
the
replace-git-proxy
branch
from
d93c288
to
23f6537
Compare
|
The integration tests are failing because the git-proxy shuts down before the autosave can be created when a session is stopped. This is exactly the problem that #951 will address. Therefore to keep the diffs sane I think that we should merge this PR first and then rebase #951 to work with this version of the git proxy. This occurs more rarely in practice (but it still does) because the old version of the git proxy does not handle the SIGTERM signal properly and waits until it receives SIGKILL from k8s 30 seconds later. This is enough in most cases to pass the integration tests. |
vigsterkr
previously approved these changes
Apr 6, 2022
Co-authored-by: Viktor Gal <vigsterkr@gmail.com>
Co-authored-by: Viktor Gal <vigsterkr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bit better maintained proxy library in Go. This will resolve all the critical security vulnerabilities we have with the current node js proxy.
I also added tests for the proxy that ensure that the Git credentials are added in the right circumstances and edited the CI pipeline so that these tests run on every push.