feat: modify for custom CA certificates #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: |
|
This is ready for review. |
|
You can access the deployment of this PR at https://renku-ci-nb-788.dev.renku.ch |
ableuler
reviewed
Jan 27, 2022
ableuler
approved these changes
Jan 27, 2022
|
I will merge this even though the integration tests are failing. The integration tests are failing due to connection issues with gitlab it seems rather than real problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify and inject any CA certificate in the notebook service. This is needed when the notebook service has to communicate with other services that are using self-signed certificates.
In addition to the changes required for injecting the certificates I also pulled out all the json patches into a separate directory and separated them into functions. This was required because the init container that injects the certificates for Amalthea has to be done in the correct order. I.e. if the git-clone init container runs first for a session then the certificates required will not be present so that the repository can be clones. Because of this and to keep the code manageable it was better to separate all the patches from the definition of the server class.
closes SwissDataScienceCenter/renku#2323
/deploy