Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): return logs from all containers #887

Merged
merged 12 commits into from Mar 14, 2022
Merged

feat(app): return logs from all containers #887

merged 12 commits into from Mar 14, 2022

Conversation

olevski
Copy link
Member

@olevski olevski commented Jan 25, 2022 •
edited

closes #869

@olevski olevski requested a review from a team as a code owner January 25, 2022 23:15
@olevski olevski linked an issue Jan 25, 2022 that may be closed by this pull request
add timestamps to logs returned by the log endpoint #680
Closed
@olevski olevski temporarily deployed to renku-ci-nb-887 January 25, 2022 23:18 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-887.dev.renku.ch

@olevski olevski temporarily deployed to renku-ci-nb-887 January 25, 2022 23:45 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 January 25, 2022 23:54 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 January 26, 2022 09:12 Inactive
Panaetius
Panaetius requested changes Jan 26, 2022
View reviewed changes
renku_notebooks/api/classes/server.py Outdated Show resolved Hide resolved
renku_notebooks/api/schemas.py Outdated Show resolved Hide resolved
renku_notebooks/api/schemas.py Outdated Show resolved Hide resolved
@olevski @Panaetius
squashme: Apply suggestions from code review
b06e2b6 
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
Panaetius
Panaetius previously approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@olevski olevski temporarily deployed to renku-ci-nb-887 January 26, 2022 09:40 Inactive
@olevski
Copy link
Member Author

olevski commented Jan 26, 2022

NOTE: This will break the UI. It should be merged together with the corresponding change on the UI side. This is the related issue on the UI side: SwissDataScienceCenter/renku-ui#1647

Panaetius
Panaetius previously approved these changes Jan 26, 2022
View reviewed changes
@olevski olevski mentioned this pull request Jan 26, 2022
Closed
@olevski olevski temporarily deployed to renku-ci-nb-887 January 28, 2022 13:03 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 February 9, 2022 22:53 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 February 10, 2022 01:32 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 February 14, 2022 09:39 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 February 15, 2022 08:48 Inactive
Panaetius
Panaetius previously approved these changes Feb 16, 2022
View reviewed changes
@olevski olevski temporarily deployed to renku-ci-nb-887 February 21, 2022 18:24 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-887 March 1, 2022 09:17 Inactive
@olevski olevski requested a review from Panaetius March 1, 2022 09:18
@olevski
Copy link
Member Author

olevski commented Mar 1, 2022

I am sorry @Panaetius the approval got dismissed because I had to resolve some merge conflicts. Can you re-approve please?

@olevski olevski temporarily deployed to renku-ci-nb-887 March 10, 2022 15:53 Inactive
@olevski olevski deployed to renku-ci-nb-887 March 11, 2022 09:36 Active
@olevski olevski merged commit 3defae5 into master Mar 14, 2022
@olevski olevski deleted the get-all-session-logs branch March 14, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return logs from all containers in the session add timestamps to logs returned by the log endpoint
3 participants
@olevski @RenkuBot @Panaetius