Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep 0.3.2 #21

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Prep 0.3.2 #21

merged 4 commits into from
Apr 10, 2019

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Mar 28, 2019 •
edited
Loading

closes #20

@rokroskar rokroskar marked this pull request as ready for review April 1, 2019 21:39
@rokroskar rokroskar requested review from ableuler and erbou April 1, 2019 21:39
@rokroskar rokroskar mentioned this pull request Apr 9, 2019
Closed
jsam
jsam previously approved these changes Apr 10, 2019
View reviewed changes
0.3.2/.gitignore Show resolved Hide resolved
@rokroskar rokroskar requested a review from jsam April 10, 2019 13:06
@rokroskar rokroskar merged commit c9ac3ff into master Apr 10, 2019
@rokroskar rokroskar deleted the prep-0.3.2 branch April 10, 2019 13:13
@erbou
Copy link

erbou commented Apr 11, 2019

In fix a280d59, do not send data and notebooks, should we also ignore .git? another option would be to put the Dockerfile and requirements etc in an env folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsam jsam jsam approved these changes

@ableuler ableuler Awaiting requested review from ableuler

@erbou erbou Awaiting requested review from erbou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit scope of Docker build context when building an image
3 participants
@rokroskar @erbou @jsam