-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New templates #28
New templates #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's missing is metadata describing the template (e.g., a name we can show in the UI). The original idea is that this would go in the template folders (python-minimal
, R-minimal
), but I think it would be better to have this in a separate file, for example manifest.yaml
. This will be more efficient, since we initially only need to make one request to retrieve one file from the template repository.
I suggest something like this for the structure:
-
folder: python-minimal
name: Basic Python Project
-
folder: R-minimal
name: Basic R Project
This can later be expanded if necessary.
How about: templates:
python-minimal:
folder: python-minimal
name: Basic Python Project
description: The simplest renku project with a basic directory structure and necessary supporting files. |
I considered something like this, but it makes it more difficult for the creator of templates to control the order in which they appear. For me, that was an argument against this, but maybe it doesn't matter. |
Agreed, should be a list |
The other thing to consider here is whether we want to make these cookie-cutter compatible? That would make it cleaner for creating projects in the CLI, but I don't know if cookie-cutter would support this sort of structure (where different templates are parts of subdirectories). |
closes #27