resolve the template folder path (#2390)

on macOS the /tmp and /var are symlinks to /private/tmp and /private/var, which causes problems when resolving relative paths.
SwissDataScienceCenter · Oct 7, 2021 · 1009fd8 · 1009fd8
1 parent c92c5f0
commit 1009fd8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/renku/service/controllers/templates_read_manifest.py b/renku/service/controllers/templates_read_manifest.py
@@ -58,7 +58,9 @@ def template_manifest(self):
                 continue
 
             # NOTE: prevent path traversal attack
-            icon_path = template_folder / ((template_folder / template["icon"]).resolve().relative_to(template_folder))
+            icon_path = template_folder / (
+                (template_folder / template["icon"]).resolve().relative_to(template_folder.resolve())
+            )
 
             icon = Image.open(icon_path)
             icon.thumbnail(MAX_ICON_SIZE)