Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
  • Loading branch information
Viktor Gal and Panaetius committed Mar 1, 2022
1 parent b73c519 commit 37d7028
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions renku/core/commands/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -462,14 +462,14 @@ def execute_workflow(
"""Execute a Run with/without subprocesses."""
client = client_dispatcher.current_client

inputs = [i.actual_value for p in dag.nodes for i in p.inputs]
inputs = {i.actual_value for p in dag.nodes for i in p.inputs}
# NOTE: Pull inputs from Git LFS or other storage backends
if client.check_external_storage():
client.pull_paths_from_storage(*inputs)

# check whether the none generated inputs of workflows are available
outputs = set([o.actual_value for p in dag.nodes for o in p.outputs])
for i in set(inputs) - outputs:
outputs = {o.actual_value for p in dag.nodes for o in p.outputs}
for i in inputs - outputs:
if not Path(i).exists():
raise errors.ParameterError(f"Input '{i}' for the workflow does not exists!")

Expand Down

0 comments on commit 37d7028

Please sign in to comment.