fix(service): properly return cli_version in api version (#3699)

* fix(service): properly return cli_version in api version
SwissDataScienceCenter · Feb 5, 2024 · 50e20e1 · 50e20e1
1 parent 088ce15
commit 50e20e1
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 15 deletions.
diff --git a/renku/ui/service/serializers/version.py b/renku/ui/service/serializers/version.py
@@ -21,6 +21,7 @@ class VersionResponse(Schema):
     """Version response schema."""
 
     latest_version = fields.String()
+    cli_version = fields.String()
     supported_project_version = fields.Integer()
     minimum_api_version = fields.String()
     maximum_api_version = fields.String()

diff --git a/tests/service/views/test_version_views.py b/tests/service/views/test_version_views.py
@@ -26,9 +26,13 @@ def test_version(svc_client):
     assert "result" in response.json
     data = response.json["result"]
 
-    assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
-        data.keys()
-    )
+    assert {
+        "latest_version",
+        "cli_version",
+        "supported_project_version",
+        "minimum_api_version",
+        "maximum_api_version",
+    } == set(data.keys())
     assert __version__ == data["latest_version"]
     assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
     assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -38,9 +42,13 @@ def test_version(svc_client):
     assert "result" in response.json
     data = response.json["result"]
 
-    assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
-        data.keys()
-    )
+    assert {
+        "latest_version",
+        "cli_version",
+        "supported_project_version",
+        "minimum_api_version",
+        "maximum_api_version",
+    } == set(data.keys())
     assert __version__ == data["latest_version"]
     assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
     assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -50,9 +58,13 @@ def test_version(svc_client):
     assert "result" in response.json
     data = response.json["result"]
 
-    assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
-        data.keys()
-    )
+    assert {
+        "latest_version",
+        "cli_version",
+        "supported_project_version",
+        "minimum_api_version",
+        "maximum_api_version",
+    } == set(data.keys())
     assert __version__ == data["latest_version"]
     assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
     assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -62,9 +74,13 @@ def test_version(svc_client):
     assert "result" in response.json
     data = response.json["result"]
 
-    assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
-        data.keys()
-    )
+    assert {
+        "latest_version",
+        "cli_version",
+        "supported_project_version",
+        "minimum_api_version",
+        "maximum_api_version",
+    } == set(data.keys())
     assert __version__ == data["latest_version"]
     assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
     assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -74,9 +90,13 @@ def test_version(svc_client):
     assert "result" in response.json
     data = response.json["result"]
 
-    assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
-        data.keys()
-    )
+    assert {
+        "latest_version",
+        "cli_version",
+        "supported_project_version",
+        "minimum_api_version",
+        "maximum_api_version",
+    } == set(data.keys())
     assert __version__ == data["latest_version"]
     assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
     assert MINIMUM_VERSION.name == data["minimum_api_version"]