Skip to content

Commit

Permalink
fix(service): add support for using default values in template parame…
Browse files Browse the repository at this point in the history
…ters (#3550)
  • Loading branch information
Panaetius committed Jul 5, 2023
1 parent 3140f48 commit d162392
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions renku/ui/service/controllers/templates_create_project.py
Expand Up @@ -130,9 +130,10 @@ def setup_template(self):
self.template_version = repository.head.commit.hexsha

# Verify missing parameters
template_parameters = {p.name for p in self.template.parameters}
template_parameters = {p.name: p for p in self.template.parameters}
provided_parameters = {p["key"]: p["value"] for p in self.ctx["parameters"]}
missing_keys = list(template_parameters - provided_parameters.keys())
missing_keys = list(template_parameters.keys() - provided_parameters.keys())
missing_keys = [k for k in missing_keys if not template_parameters[k].has_default]
if len(missing_keys) > 0:
raise UserProjectCreationError(error_message=f"the template requires a value for '${missing_keys[0]}'")

Expand Down

0 comments on commit d162392

Please sign in to comment.