fix(cli): Fix Git LFS autocommit hook not committing new pointer files (

#2139)
SwissDataScienceCenter · Jun 8, 2021 · dca5aa4 · dca5aa4
1 parent e28e308
commit dca5aa4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/renku/data/pre-commit.sh b/renku/data/pre-commit.sh
@@ -99,6 +99,7 @@ if [ ${#ADDED_FILES[@]} -ne 0 ]; then
       files=${UNTRACKED_PATHS[*]}
       git lfs track -- "$files"
       git add .gitattributes
+      git add -- "$files"
       IFS=$saveIFS
     else
       echo 'Large files:'

diff --git a/tests/cli/test_datasets.py b/tests/cli/test_datasets.py
@@ -1413,6 +1413,7 @@ def test_lfs_hook_autocommit(runner, client, subdirectory, large_file):
     assert "You are trying to commit large files to Git instead of Git-LFS" in result[2]
     assert "Adding files to LFS" in result[2]
     assert 'Tracking "large-file"' in result[2]
+    assert len(client.dirty_paths) == 0  # NOTE: make sure repo is clean
 
 
 def test_lfs_hook_autocommit_env(runner, client, subdirectory, large_file):
@@ -1432,6 +1433,7 @@ def test_lfs_hook_autocommit_env(runner, client, subdirectory, large_file):
     assert "You are trying to commit large files to Git instead of Git-LFS" in result[2]
     assert "Adding files to LFS" in result[2]
     assert 'Tracking "large-file"' in result[2]
+    assert len(client.dirty_paths) == 0  # NOTE: make sure repo is clean
 
 
 def test_lfs_hook_can_be_avoided(runner, project, subdirectory, large_file):