Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): adds endpoints for unlinking files from a dataset #1314

Merged
merged 2 commits into from
Jun 15, 2020
Merged

feat(service): adds endpoints for unlinking files from a dataset #1314

merged 2 commits into from
Jun 15, 2020

Conversation

jsam
Copy link
Contributor

@jsam jsam commented Jun 3, 2020

closes: #776

@jsam jsam marked this pull request as ready for review June 5, 2020 12:55
@jsam jsam requested a review from a team as a code owner June 5, 2020 12:55
m-alisafaee
m-alisafaee reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a minor comment.

renku/service/views/datasets.py Outdated
interactive=False,
commit_message=ctx['commit_message']
)
unlinked = [record.name for record in records]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return path here instead of name to make the results uniquely identifiable?

@jsam jsam requested a review from m-alisafaee June 10, 2020 11:02
m-alisafaee
m-alisafaee approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@jsam jsam merged commit 1b78b16 into master Jun 15, 2020
@jsam jsam deleted the 776_svc_unlink branch June 15, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(svc): Enable unlinking a file from a dataset
2 participants
@jsam @m-alisafaee