Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): check workflow execute inputs #2727

Merged
merged 2 commits into from Mar 1, 2022
Merged

fix(core): check workflow execute inputs #2727

merged 2 commits into from Mar 1, 2022

Conversation

vigsterkr
Copy link
Contributor

Description

Fixes #2639

@vigsterkr vigsterkr requested a review from a team as a code owner March 1, 2022 08:21
Panaetius
Panaetius previously approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't have a comment on anything functional, just some unneeded lists that could be sets directly.

renku/core/commands/workflow.py Outdated Show resolved Hide resolved
renku/core/commands/workflow.py Outdated Show resolved Hide resolved
@Panaetius
Apply suggestions from code review
37d7028 
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
@vigsterkr vigsterkr enabled auto-merge (squash) March 1, 2022 09:33
@vigsterkr vigsterkr merged commit 0bfceaf into develop Mar 1, 2022
@vigsterkr vigsterkr deleted the feature/fix-2639 branch March 1, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rerun fails when the script has been moved
2 participants
@vigsterkr @Panaetius