New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): option to skip metadata update #3025
Conversation
9e1978b
to
7d2645d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, thank you!
We should probably add it for other execution commands as well (renku update/renku rerun/renku workflow iterate)
oh also, documentation of the parameter in the docstring of the files at the top of the renku.ui.cli.* files and we maybe should add a shorthand flag for the |
Done you can use |
I also added the
And I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
27d009d
to
686ae72
Compare
@Panaetius I am sorry for making you re-approve this. I had some issues with the style checks. My pre-commit hooks are broken it seems. Or that specific style check is not enforced by the pre-commit tests. Anyhow now the style check passes. |
Ok the problem is that |
6dd0e2e
to
3616b70
Compare
3616b70
to
7496d24
Compare
70e9132
to
0a303c9
Compare
This is a feature that can be useful in cases where the metadata update can happen elsewhere (i.e. argo workflow) or simply should not be committed.
For example running tests or troubleshooting things should not be tracked.
I was not sure where to exactly put the logic. I can move it up or down the chain of depedencies. I.e. we can have a whole new function called
run_without_metadata_update
instead of passing the skip metadata flag in the current function.closes #3020