feat(cli): option to skip metadata update

renku/ui/cli/rerun.py

@@ -54,7 +54,7 @@
 In some cases it may be desirable to avoid updating the renku metadata
 and to avoid committing this and any other change in the repository when the rerun
 command is used. If this is the case then you can pass the ``--skip-metadata-update``
-flag (or simply ``-s``) to ``renku rerun``.
+flag to ``renku rerun``.
 
 .. cheatsheet::
    :group: Running
@@ -74,7 +74,7 @@
 
 @click.command()
 @click.option("--dry-run", "-n", is_flag=True, default=False, help="Show a preview of plans that will be executed.")
-@click.option("-s", "--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
+@click.option("--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
 @click.option(
     "--from",
     "sources",

renku/ui/cli/update.py

@@ -79,7 +79,7 @@
 In some cases it may be desirable to avoid updating the renku metadata
 and to avoid committing this and any other change in the repository when the update
 command is run. If this is the case then you can pass the ``--skip-metadata-update``
-flag (or simply ``-s``) to ``renku update``.
+flag to ``renku update``.
 
 .. cheatsheet::
    :group: Running
@@ -172,7 +172,7 @@
     "config", "-c", "--config", metavar="<config file>", help="YAML file containing configuration for the provider."
 )
 @click.option("-i", "--ignore-deleted", is_flag=True, help="Ignore deleted paths.")
-@click.option("-s", "--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
+@click.option("--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
 def update(update_all, dry_run, paths, provider, config, ignore_deleted, skip_metadata_update):
     """Update existing files by rerunning their outdated workflow."""
     from renku.command.format.activity import tabulate_activities

renku/ui/cli/workflow.py

@@ -152,7 +152,7 @@
 In some cases it may be desirable to avoid updating the renku metadata
 and to avoid committing this and any other change in the repository when a workflow
 is executed. If this is the case then you can pass the ``--skip-metadata-update``
-flag (or simply ``-s``) to ``renku workflow execute``.
+flag to ``renku workflow execute``.
 
 Iterate Plans
 *************
@@ -220,7 +220,7 @@
 In some cases it may be desirable to avoid updating the renku metadata
 and to avoid committing this and any other change in the repository when a workflow
 is iterated through. If this is the case then you can pass the ``--skip-metadata-update``
-flag (or simply ``-s``) to ``renku workflow iterate``.
+flag to ``renku workflow iterate``.
 
 Exporting Plans
 ***************
@@ -1093,7 +1093,7 @@ def outputs(ctx, paths):
     type=click.Path(exists=True, dir_okay=False),
     help="YAML file containing parameter mappings to be used.",
 )
-@click.option("-s", "--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
+@click.option("--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
 @click.argument("name_or_id", required=True, shell_complete=_complete_workflows)
 def execute(
     provider,
@@ -1208,7 +1208,7 @@ def visualize(sources, columns, exclude_files, ascii, interactive, no_color, pag
 
 
 @workflow.command()
-@click.option("-s", "--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
+@click.option("--skip-metadata-update", is_flag=True, help="Do not update the metadata store for the execution.")
 @click.option(
     "mapping_path",
     "--mapping",

tests/cli/test_rerun.py

@@ -47,7 +47,7 @@ def test_rerun(project, client, client_database_injection_manager, renku_cli, pr
     def rerun():
         cmd = ["rerun", "-p", provider]
         if skip_metadata_update:
-            cmd.append("-s")
+            cmd.append("--skip-metadata-update")
         cmd.append(output)
         assert 0 == renku_cli(*cmd).exit_code
         with client_database_injection_manager(client):

tests/cli/test_update.py

@@ -48,7 +48,7 @@ def test_update(runner, client, renku_cli, client_database_injection_manager, pr
 
     cmd = ["update", "-p", provider, "--all"]
     if skip_metadata_update:
-        cmd.append("-s")
+        cmd.append("--skip-metadata-update")
     exit_code, activity = renku_cli(*cmd)
 
     assert 0 == exit_code
@@ -100,7 +100,7 @@ def test_update_multiple_steps(
 
     cmd = ["update", "-p", provider, "--all"]
     if skip_metadata_update:
-        cmd.append("-s")
+        cmd.append("--skip-metadata-update")
     exit_code, activities = renku_cli(*cmd)
 
     assert 0 == exit_code

tests/cli/test_workflow.py

@@ -22,7 +22,6 @@
 import logging
 import os
 import re
-import sys
 import tempfile
 import uuid
 from pathlib import Path
@@ -1133,7 +1132,7 @@ def test_workflow_iterate(
     iteration_cmd = ["renku", "workflow", "iterate", "-p", provider]
     outputs = []
     if skip_metadata_update:
-        iteration_cmd.append("-s")
+        iteration_cmd.append("--skip-metadata-update")
     iteration_cmd.append(workflow_name)
     index_re = re.compile(r"{iter_index}")
 
@@ -1253,7 +1252,7 @@ def test_workflow_cycle_detection(run_shell, project, capsys, client):
     assert b"Cycles detected in execution graph" in result[0]
 
 
-@pytest.mark.skipif(sys.platform == "darwin", reason="GitHub macOS image doesn't include Docker")
+# @pytest.mark.skipif(sys.platform == "darwin", reason="GitHub macOS image doesn't include Docker")
 def test_workflow_execute_docker_toil(runner, client, run_shell, caplog):
     """Test workflow execute using docker with the toil provider."""
     caplog.set_level(logging.INFO)