New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update template checksum when updating Dockerfile #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
3346-dockerfile-update-fix
branch
from
March 7, 2023 10:05
9d671be
to
74ad931
Compare
m-alisafaee
force-pushed
the
3346-dockerfile-update-fix
branch
from
March 7, 2023 12:20
74ad931
to
a1b882a
Compare
m-alisafaee
force-pushed
the
3346-dockerfile-update-fix
branch
from
March 7, 2023 15:48
a1b882a
to
aff732e
Compare
Panaetius
reviewed
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but looks good to go
Panaetius
previously approved these changes
Mar 8, 2023
Panaetius
previously approved these changes
Mar 8, 2023
m-alisafaee
force-pushed
the
3346-dockerfile-update-fix
branch
from
March 9, 2023 15:10
a089b56
to
5ccb407
Compare
m-alisafaee
force-pushed
the
3346-dockerfile-update-fix
branch
from
March 9, 2023 15:58
5ccb407
to
a5612a6
Compare
Panaetius
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We check Dockerfile changes in each commit and if they are only Renku version updates, we mark the Dockerfile as not being modified by users. Before doing this, we first check its checksum and checksum at time that the template was set to see if they match with the stored checksum; if so, we skip the git history traversal.
This PR also refactors
templates_source
fixture to use actual business models instead of a dummy template source.Fixes #3346