Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): fixes importing private datasets in deployments with external gitlab #3523

Merged
merged 1 commit into from Jun 14, 2023

Conversation

Panaetius
Copy link
Member

closes #3500

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5255484813

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+1.1%) to 87.06%

Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/infrastructure/repository.py 1 81.41%
renku/ui/cli/init.py 1 96.9%
renku/core/util/git.py 2 85.27%
renku/core/util/os.py 2 88.38%
renku/core/dataset/context.py 3 91.43%
renku/core/dataset/dataset.py 3 85.31%
renku/ui/service/controllers/api/mixins.py 3 78.79%
renku/ui/cli/service.py 13 62.69%
Totals Coverage Status
Change from base Build 5212908161: 1.1%
Covered Lines: 26152
Relevant Lines: 30039

💛 - Coveralls

@Panaetius Panaetius merged commit d64c179 into develop Jun 14, 2023
30 of 32 checks passed
@Panaetius Panaetius deleted the fix/3500-fix-project-token-forwarding branch June 14, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dataset import in core-svc should check against actual host URL to determine token safety
3 participants