Skip to content

Dataset import in core-svc should check against actual host URL to determine token safety #3500

@Panaetius

Description

@Panaetius

In

def _is_safe_to_pass_gitlab_token(project_git_url, dataset_uri):
we currently check if a datasets host matches the projects gitlab URL host to see if it's safe to forward the gitlab token. We should instead check the datasets host vs the configured RENKU_DOMAIN to determine if it's safe.
otherwise, dataset import does not work on deployments where gitlab is hosted under a different URL (e.g. CI deployments)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions