Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): correct bad plan ID format #3594

Merged
merged 1 commit into from Aug 18, 2023
Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 18, 2023

closes #3592

@coveralls
Copy link
Collaborator

coveralls commented Aug 18, 2023

Pull Request Test Coverage Report for Build 5900666129

  • 28 of 34 (82.35%) changed or added relevant lines in 3 files are covered.
  • 36 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.1%) to 85.694%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/command/checks/workflow.py 17 20 85.0%
renku/ui/service/serializers/workflows.py 10 13 76.92%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/infrastructure/repository.py 1 81.57%
renku/ui/cli/init.py 1 96.9%
renku/ui/service/cache/models/file.py 1 93.15%
renku/command/rollback.py 2 78.7%
renku/ui/service/jobs/cleanup.py 2 80.65%
renku/core/dataset/context.py 3 91.43%
renku/core/util/git.py 4 84.68%
renku/ui/service/gateways/repository_cache.py 7 58.54%
Totals Coverage Status
Change from base Build 5865855273: -0.1%
Covered Lines: 25842
Relevant Lines: 30156

💛 - Coveralls

Panaetius
Panaetius previously approved these changes Aug 18, 2023
@olevski olevski enabled auto-merge (squash) August 18, 2023 08:49
@olevski olevski merged commit b358923 into develop Aug 18, 2023
26 of 27 checks passed
@olevski olevski deleted the fix-3592-broken-plans-id branch August 18, 2023 09:18
olevski added a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix broken //plans id in core-svc as well
3 participants