Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): do not freeze/unfreeze plan view model #3599

Merged
merged 5 commits into from Aug 23, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 22, 2023

Introduced a bug as part of #3594.

This removes it.

Panaetius
Panaetius previously approved these changes Aug 22, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 22, 2023

Pull Request Test Coverage Report for Build 5943996693

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • 361 unchanged lines in 33 files lost coverage.
  • Overall coverage decreased (-1.1%) to 85.75%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/domain_model/dataset.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/common.py 1 94.44%
renku/core/dataset/providers/repository.py 1 88.46%
renku/core/dataset/providers/s3.py 1 96.25%
renku/core/dataset/providers/web.py 1 89.91%
renku/core/migration/models/v3.py 1 97.24%
renku/core/storage.py 1 79.79%
renku/core/util/os.py 1 88.89%
renku/core/workflow/activity.py 1 93.61%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 74.07%
Totals Coverage Status
Change from base Build 5943195059: -1.1%
Covered Lines: 25858
Relevant Lines: 30155

💛 - Coveralls

@olevski olevski enabled auto-merge (squash) August 22, 2023 16:51
Panaetius
Panaetius previously approved these changes Aug 22, 2023
@olevski olevski force-pushed the fix-do-not-freeze-view-model branch from f96ca8b to 53c836b Compare August 22, 2023 21:01
@olevski olevski requested a review from Panaetius August 23, 2023 02:59
@olevski olevski merged commit 3c48cff into develop Aug 23, 2023
29 checks passed
@olevski olevski deleted the fix-do-not-freeze-view-model branch August 23, 2023 05:56
olevski added a commit that referenced this pull request Aug 23, 2023
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants