Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds sorting to file listing #960

Merged
merged 8 commits into from
Jan 30, 2020
Merged

fix: adds sorting to file listing #960

merged 8 commits into from
Jan 30, 2020

Conversation

jsam
Copy link
Contributor

@jsam jsam commented Jan 28, 2020

closes: #935

@jsam jsam requested a review from a team as a code owner January 28, 2020 10:17
rokroskar
rokroskar requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - since the change is about sorting, it would be nice to test that the file paths are also sorted correctly

tests/service/test_cache_views.py
assert 3 == len(response.json['result']['files'])

uploaded_dir = response.json['result']['files'].pop()
assert uploaded_dir['is_dir']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want to check also that they were sorted by path?

@jsam jsam merged commit bcf6bcd into master Jan 30, 2020
@jsam jsam deleted the 935_sort_file_listing branch January 30, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokroskar rokroskar rokroskar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(svc): sort listing of cached files
2 participants
@jsam @rokroskar