Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset): explicit failure when cannot pull LFS objects #1590

Merged
merged 3 commits into from Oct 12, 2020

Conversation

m-alisafaee
Copy link
Contributor

Description

Do not ignore missing LFS objects when importing or adding from a git repository.

Fixes #1303

@m-alisafaee m-alisafaee marked this pull request as ready for review October 8, 2020 08:45
@m-alisafaee m-alisafaee requested a review from a team as a code owner October 8, 2020 08:45
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@m-alisafaee m-alisafaee merged commit 3b05816 into master Oct 12, 2020
@m-alisafaee m-alisafaee deleted the 1303-fail-on-missing-lfs-objects branch October 12, 2020 18:08
m-alisafaee added a commit that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing LFS objects not handled correctly
2 participants