Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(service): v1.0.4 unlimited file size in nginx config #2609

Merged
merged 1 commit into from Jan 28, 2022

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented Jan 28, 2022

Description

Reverse-proxy NginX in multi core-service deployment has a limited packet size which prevents uploading large files when adding files to datasets in the UI.
This PR makes it accept unlimited messages. We should revert this back once chunked upload is implemented in the service (#910).

/deploy renku=1.0-next renku-graph=development renku-ui=master

@m-alisafaee m-alisafaee temporarily deployed to renku-ci-rp-2609 January 28, 2022 09:16 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-2609.dev.renku.ch

@m-alisafaee m-alisafaee deployed to renku-ci-rp-2609 January 28, 2022 09:51 Active
Copy link

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem; thanks a lot! 🎉

@m-alisafaee m-alisafaee marked this pull request as ready for review January 28, 2022 10:47
@m-alisafaee m-alisafaee changed the title fix(service): unlimited file size in nginx config hotfix(service): v1.0.4 unlimited file size in nginx config Jan 28, 2022
@m-alisafaee m-alisafaee merged commit e1d40f3 into master Jan 28, 2022
@m-alisafaee m-alisafaee deleted the bugfix-upload-size-limit branch January 28, 2022 12:41
m-alisafaee added a commit that referenced this pull request Jan 28, 2022
hotfix(service): v1.0.4 unlimited file size in nginx config (#2609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants