-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add renku session RFC #2687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Are the last two sections meant to be blank - ie just have questions with no answers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks @vigsterkr for separating it out from the implementation. I still don't fully understand how you intend to find the sessions in commands that require a session ID without knowing which provider to query. I guess it might not matter much in practice, but it seems unnecessary to fetch all lists of sessions from all providers every time. Either we should encode the provider name in the session id, e.g.
renkulab.io/<id>
docker/<id>
or use a --provider
flag in those commands as well. I prefer the first option because it's less typing for the user... but we have to come up with a good scheme.
the primary reason was to avoid the explicit mentioning of the provider in some cases (see when dealing with |
That's fine - the default can be to cycle through all of them but having a consistent interface where one can specify a provider makes sense to me. |
2222db4
to
5d09c87
Compare
Co-authored-by: Rok Roškar <roskarr@ethz.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small comments but then I think we're finally done :)
Description
add the
renku session
sub-command RFC