feat(core): consistent template versioning #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
2714-consistent-template-versioning
branch
from
639d1ab
to
94d25dc
Compare
m-alisafaee
force-pushed
the
2714-consistent-template-versioning
branch
from
94d25dc
to
9c784ad
Compare
Panaetius
reviewed
Mar 21, 2022
|
|
||
| latest_reference, latest_version = latest | ||
| update_available = latest_reference != reference or latest_version != version | ||
| return update_available, latest_reference |
There was a problem hiding this comment.
This would mean that if I install hypothetical version 1.3.0 and migrate, and then install hypothetical version 1.2.0 and run migration check, it'd say a new version is available and downgrade, right?
There was a problem hiding this comment.
No, EmbeddedTemplates::get_latest_reference_and_version checks if project's template version is newer than renku's template version and returns the latest of the two, so, 1.3.0 will be the latest version/reference in that case and nothing will be changed.
Panaetius
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use template repository's tag as version (instead of the Renku version) for templates bundled with Renku CLI.
Fixes #2714