Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): add git user configuration to local session #2877

Merged
merged 10 commits into from May 12, 2022
Merged

fix(cli): add git user configuration to local session #2877

merged 10 commits into from May 12, 2022

Conversation

Panaetius
Copy link
Member

closes #2857

Copies over ~/.gitconfig if it exists, otherwise sets environment variables.

@Panaetius Panaetius requested a review from a team as a code owner May 2, 2022 15:39
rokroskar
rokroskar requested changes May 3, 2022
View reviewed changes
renku/core/session/docker.py Outdated Show resolved Hide resolved
renku/core/session/docker.py Outdated Show resolved Hide resolved
@Panaetius Panaetius requested a review from rokroskar May 10, 2022 05:45
rokroskar
rokroskar reviewed May 10, 2022
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use something more intelligent for path concatenation than an f-string... unless there's good reason not to do it.

renku/core/session/docker.py Outdated Show resolved Hide resolved
@Panaetius Panaetius requested a review from rokroskar May 10, 2022 08:41
@Panaetius Panaetius force-pushed the bugfix/2857-session-docker-git-user branch from 2e34f41 to ff93257 Compare May 10, 2022 15:10
@Panaetius Panaetius force-pushed the bugfix/2857-session-docker-git-user branch from 8ae30c5 to 80c8c36 Compare May 10, 2022 15:43
@Panaetius Panaetius force-pushed the bugfix/2857-session-docker-git-user branch from fa84943 to 4c30359 Compare May 10, 2022 16:24
rokroskar
rokroskar approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works now as expected - thanks @Panaetius!!

m-alisafaee
m-alisafaee approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Panaetius Panaetius enabled auto-merge (squash) May 12, 2022 08:07
@Panaetius Panaetius merged commit 089488b into develop May 12, 2022
@Panaetius Panaetius deleted the bugfix/2857-session-docker-git-user branch May 12, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokroskar rokroskar rokroskar approved these changes

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git not properly configured in container started with renku session
3 participants
@Panaetius @rokroskar @m-alisafaee