Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): support chunked file uploads #2892

Merged
merged 14 commits into from Jun 29, 2022
Merged

feat(service): support chunked file uploads #2892

merged 14 commits into from Jun 29, 2022

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented May 9, 2022 •
edited

closes #910

This should work with a frontend like

<html>
<head>
<script src="https://unpkg.com/dropzone@5/dist/min/dropzone.min.js"></script>
<link rel="stylesheet" href="https://unpkg.com/dropzone@5/dist/min/dropzone.min.css" type="text/css" />
</head>
<body>
    <script>
  // Note that the name "myAwesomeDropzone" is the camelized
  // id of the form.
  Dropzone.options.myDropzone = {
    headers:{"Authorization":'Bearer xxxxx'}, 
  };
</script>
        <form action="https://renku-ci-rp-2892.dev.renku.ch/api/renku/cache.files_upload"
      class="dropzone"
      id="my-awesome-dropzone"></form>
</body>
</html>

/deploy #persist extra-values=gateway.allowOrigin={"*"}

@Panaetius Panaetius force-pushed the feature/910-chunked-uploads branch from e9475a6 to 11eb1a7 Compare May 9, 2022 13:32
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 13:32 Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented May 9, 2022

You can access the deployment of this PR at https://renku-ci-rp-2892.dev.renku.ch

@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 13:45 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 13:53 Inactive
@Panaetius Panaetius force-pushed the feature/910-chunked-uploads branch from 11eb1a7 to 6571ec4 Compare May 9, 2022 14:14
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 14:15 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 14:41 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 14:56 Inactive
@Panaetius Panaetius force-pushed the feature/910-chunked-uploads branch from 6571ec4 to c2bf9c0 Compare May 9, 2022 15:04
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 9, 2022 15:05 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 10, 2022 06:49 Inactive
@Panaetius Panaetius force-pushed the feature/910-chunked-uploads branch from c2bf9c0 to 11125d6 Compare May 10, 2022 06:54
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 10, 2022 06:54 Inactive
@ciyer ciyer mentioned this pull request May 10, 2022
Closed
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 17, 2022 08:13 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 17, 2022 08:36 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 May 17, 2022 13:56 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 14, 2022 12:45 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 14, 2022 15:18 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 15, 2022 12:20 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 20, 2022 10:13 Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 20, 2022 18:50 Inactive
@Panaetius Panaetius force-pushed the feature/910-chunked-uploads branch from 42bd578 to 10a15a9 Compare June 21, 2022 07:55
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 21, 2022 07:55 Inactive
@Panaetius Panaetius removed the on hold label Jun 27, 2022
@Panaetius Panaetius marked this pull request as ready for review June 27, 2022 08:32
@Panaetius Panaetius requested a review from a team as a code owner June 27, 2022 08:32
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 27, 2022 08:32 Inactive
m-alisafaee
m-alisafaee requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! This looks great! Please see my comments.

helm-chart/renku-core/values.yaml Show resolved Hide resolved
renku/ui/service/cache/models/file.py Outdated Show resolved Hide resolved
renku/ui/service/controllers/cache_files_delete_chunks.py Outdated Show resolved Hide resolved
renku/ui/service/controllers/cache_files_delete_chunks.py Outdated Show resolved Hide resolved
renku/ui/service/controllers/cache_files_delete_chunks.py Show resolved Hide resolved
renku/ui/service/controllers/cache_files_upload.py Outdated Show resolved Hide resolved
tests/service/views/test_cache_views.py Outdated Show resolved Hide resolved
@Panaetius Panaetius force-pushed the feature/910-chunked-uploads branch from 4c302fc to 5152826 Compare June 28, 2022 14:10
@Panaetius Panaetius temporarily deployed to renku-ci-rp-2892 June 28, 2022 14:11 Inactive
m-alisafaee
m-alisafaee previously approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Panaetius Panaetius deployed to renku-ci-rp-2892 June 29, 2022 07:25 Active
@Panaetius Panaetius merged commit 610e88a into develop Jun 29, 2022
@Panaetius Panaetius deleted the feature/910-chunked-uploads branch June 29, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-code andre-code andre-code left review comments

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

svc: enable chunked uploads for large files
4 participants
@Panaetius @RenkuBot @andre-code @m-alisafaee