feat(core): use existing remote image when starting sessions #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
2934-use-existing-image-for-sessions
branch
from
1ec9415
to
354dec3
Compare
m-alisafaee
force-pushed
the
2934-use-existing-image-for-sessions
branch
from
354dec3
to
7911719
Compare
I've checked that issue and it seems that it's fixed by this PR. I wrote a comment there but left it open so that Laura can check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2880 already pulls a remote image if it exists when a local image is not found. However, it wasn't clear that it's doing this. This PR adds proper progress messages. It also solves some issues with stoping sessions and for cases where a session is starting/stoping/... for projects with no remote.
It also renames
session listtosession lsto be consistent with other commands.Fixes #2934