-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): remove LocalClient #3139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
from
September 26, 2022 21:12
009c772
to
20cf9ed
Compare
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
from
October 2, 2022 22:25
8552ba7
to
30bf0a3
Compare
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
from
October 2, 2022 23:18
b7073ec
to
4ef9699
Compare
Panaetius
requested changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few places left that I saw:
- Docstring of
transaction_id
inproject_context.py
renku.domain_model.datastructures.py
, I think onlyDirectoryTree
in this files is actually used and the rest can be deleted.tests/utils.py
with_dataset
, but that can be removed I think.- And of course the 5 billion
client
fixtures you already mentioned. There's alsosvc_client*
but I guess in that case, it's actually a client and fine.
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
3 times, most recently
from
October 3, 2022 23:53
095864b
to
1e6855a
Compare
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
4 times, most recently
from
October 4, 2022 12:54
330c094
to
faf87f4
Compare
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
2 times, most recently
from
October 5, 2022 16:25
c0e3caf
to
9acca8e
Compare
m-alisafaee
force-pushed
the
3083-remove-local-client
branch
from
October 5, 2022 16:31
a186e25
to
f06f7d7
Compare
Panaetius
requested changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea on adding path
to the project
fixture. And thank you for all the little cleanups you did!
Panaetius
previously approved these changes
Oct 6, 2022
Panaetius
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3083
Test Refactoring:
project
fixture (an instance ofRenkuProject
class) to represent a project consistently. Removes therepository
fixture.client
,client_*
, ... fixtures withproject
onesload_dataset_with_injection
andget_datasets_provenance_with_injection
fixtures with functionswith_injections_manager
towith_injection
migrate.py
fromrenku.core
torenku.core.migration
project_context
in the test as much as possible