Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove LocalClient #3139

Merged
merged 10 commits into from
Oct 7, 2022
Merged

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented Sep 25, 2022

Fixes #3083

Test Refactoring:

  • Uses a project fixture (an instance of RenkuProject class) to represent a project consistently. Removes the repository fixture.
  • Replaces all client, client_*, ... fixtures with project ones
  • Replaces load_dataset_with_injection and get_datasets_provenance_with_injection fixtures with functions
  • Renames with_injections_manager to with_injection
  • Moves migrate.py from renku.core to renku.core.migration
  • Removes usages of project_context in the test as much as possible
  • Some renaming, spelling fixes, ...

@m-alisafaee m-alisafaee marked this pull request as ready for review October 3, 2022 07:30
@m-alisafaee m-alisafaee requested a review from a team as a code owner October 3, 2022 07:30
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few places left that I saw:

  • Docstring of transaction_id in project_context.py
  • renku.domain_model.datastructures.py, I think only DirectoryTree in this files is actually used and the rest can be deleted.
  • tests/utils.py with_dataset, but that can be removed I think.
  • And of course the 5 billion client fixtures you already mentioned. There's also svc_client* but I guess in that case, it's actually a client and fine.

renku/command/command_builder/command.py Outdated Show resolved Hide resolved
renku/core/dataset/dataset.py Outdated Show resolved Hide resolved
renku/core/dataset/dataset.py Outdated Show resolved Hide resolved
renku/core/util/contexts.py Outdated Show resolved Hide resolved
@m-alisafaee m-alisafaee marked this pull request as draft October 3, 2022 09:32
@m-alisafaee m-alisafaee force-pushed the 3083-remove-local-client branch 3 times, most recently from 095864b to 1e6855a Compare October 3, 2022 23:53
@m-alisafaee m-alisafaee force-pushed the 3083-remove-local-client branch 4 times, most recently from 330c094 to faf87f4 Compare October 4, 2022 12:54
@m-alisafaee m-alisafaee force-pushed the 3083-remove-local-client branch 2 times, most recently from c0e3caf to 9acca8e Compare October 5, 2022 16:25
@m-alisafaee m-alisafaee marked this pull request as ready for review October 5, 2022 22:24
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea on adding path to the project fixture. And thank you for all the little cleanups you did!

renku/domain_model/project.py Outdated Show resolved Hide resolved
Panaetius
Panaetius previously approved these changes Oct 6, 2022
@m-alisafaee m-alisafaee merged commit f8184bd into develop Oct 7, 2022
@m-alisafaee m-alisafaee deleted the 3083-remove-local-client branch October 7, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

remove LocalClient and (I)ClientDispatcher
2 participants