Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataset): store s3 credentials per bucket #3339

Merged
merged 1 commit into from
Mar 10, 2023
Merged

feat(dataset): store s3 credentials per bucket #3339

merged 1 commit into from
Mar 10, 2023

Conversation

m-alisafaee
Copy link
Contributor

Fixes #3280

@coveralls
Copy link
Collaborator

coveralls commented Mar 2, 2023 •
edited

Pull Request Test Coverage Report for Build 4385010450

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+86.7%) to 86.679%
Totals Coverage Status
Change from base Build 4384988074: 86.7%
Covered Lines: 25612
Relevant Lines: 29548
💛 - Coveralls

@m-alisafaee m-alisafaee marked this pull request as ready for review March 2, 2023 15:26
@m-alisafaee m-alisafaee requested a review from a team as a code owner March 2, 2023 15:26
@Panaetius
Copy link
Member

This would fail for anyone already having stored credentials, correct?

@m-alisafaee m-alisafaee marked this pull request as draft March 2, 2023 16:26
@m-alisafaee m-alisafaee marked this pull request as ready for review March 2, 2023 22:59
@m-alisafaee
Copy link
Contributor Author

This would fail for anyone already having stored credentials, correct?

Yes. The section name in renku.ini is changed for S3 credentials and we don't look in the old place.

Panaetius
Panaetius previously approved these changes Mar 6, 2023
View reviewed changes
@m-alisafaee m-alisafaee enabled auto-merge (squash) March 10, 2023 14:09
@m-alisafaee m-alisafaee merged commit 717a780 into develop Mar 10, 2023
@m-alisafaee m-alisafaee deleted the 3280-s3-cred-per-bucket branch March 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow storing S3 credentials per bucket
3 participants
@m-alisafaee @coveralls @Panaetius