Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support rsync-style syntax using / in dataset add #3362

Merged
merged 2 commits into from Mar 16, 2023
Merged

feat(cli): support rsync-style syntax using / in dataset add #3362

merged 2 commits into from Mar 16, 2023

Conversation

Panaetius
Copy link
Member

closes #3283

@Panaetius Panaetius requested a review from a team as a code owner March 14, 2023 10:04
@Panaetius Panaetius force-pushed the feature/3283-dataset-add-rsync-syntax branch from ce5ec5c to 55415e6 Compare March 14, 2023 10:15
@coveralls
Copy link
Collaborator

coveralls commented Mar 14, 2023 •
edited

Pull Request Test Coverage Report for Build 4435022551

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+86.8%) to 86.8%
Totals Coverage Status
Change from base Build 4429336950: 86.8%
Covered Lines: 25606
Relevant Lines: 29500
💛 - Coveralls

@Panaetius Panaetius force-pushed the feature/3283-dataset-add-rsync-syntax branch from 55415e6 to 47fee48 Compare March 14, 2023 10:28
@Panaetius Panaetius force-pushed the feature/3283-dataset-add-rsync-syntax branch from 47fee48 to d89c11a Compare March 14, 2023 10:31
m-alisafaee
m-alisafaee approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Panaetius Panaetius enabled auto-merge (squash) March 16, 2023 08:31
@Panaetius Panaetius merged commit 57520c3 into develop Mar 16, 2023
27 of 28 checks passed
@Panaetius Panaetius deleted the feature/3283-dataset-add-rsync-syntax branch March 16, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use rsync syntax when adding data to a dataset
3 participants
@Panaetius @coveralls @m-alisafaee