Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): limit commit message length when there is too many files #3375

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

Panaetius
Copy link
Member

closes #3355

With many files, the commit message could get too long for an argument on the command line.

We could save it to a file and pass that to git, but then, what's the point of having an overly long commit message.

@coveralls
Copy link
Collaborator

coveralls commented Mar 21, 2023

Pull Request Test Coverage Report for Build 4524113903

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+85.9%) to 85.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/util/git.py 4 5 80.0%
Totals Coverage Status
Change from base Build 4524113155: 85.9%
Covered Lines: 25634
Relevant Lines: 29830

💛 - Coveralls

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius Panaetius merged commit 70cf36a into develop Mar 27, 2023
@Panaetius Panaetius deleted the bugfix/3355-renku-save-batch-size branch March 27, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

issue using "renku save"
3 participants