Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): raise proper errors when Renku metadata is corrupt #3393

Merged
merged 6 commits into from
Apr 28, 2023
Merged

feat(core): raise proper errors when Renku metadata is corrupt #3393

merged 6 commits into from
Apr 28, 2023

Conversation

Panaetius
Copy link
Member

closes #3374

@Panaetius Panaetius requested a review from a team as a code owner April 12, 2023 09:39
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2023 •
edited

Pull Request Test Coverage Report for Build 4828823529

  • 18 of 20 (90.0%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 85.336%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/errors.py 5 6 83.33%
renku/ui/service/views/error_handlers.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
renku/core/workflow/activity.py 1 93.61%
renku/infrastructure/repository.py 1 81.7%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.59%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 4828779205: 0.01%
Covered Lines: 25565
Relevant Lines: 29958
💛 - Coveralls

@Panaetius Panaetius force-pushed the feature/3374-proper-error-for-corrupt-metadata branch from 0c1b526 to 6c9745e Compare April 12, 2023 13:47
m-alisafaee
m-alisafaee requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank! Please see my comment.

renku/ui/service/errors.py Outdated Show resolved Hide resolved
@Panaetius Panaetius enabled auto-merge (squash) April 24, 2023 08:49
@Panaetius Panaetius merged commit bb0a39a into develop Apr 28, 2023
29 checks passed
@Panaetius Panaetius deleted the feature/3374-proper-error-for-corrupt-metadata branch April 28, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message on corrupt metadata files
3 participants
@Panaetius @coveralls @m-alisafaee