Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused code in renku lfs migrate #3476

Merged
merged 2 commits into from May 25, 2023
Merged

chore: remove unused code in renku lfs migrate #3476

merged 2 commits into from May 25, 2023

Conversation

Panaetius
Copy link
Member

closes #3440

@Panaetius Panaetius requested a review from a team as a code owner May 23, 2023 14:04
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023 •
edited

Pull Request Test Coverage Report for Build 5079340216

  • 30 of 32 (93.75%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.07%) to 85.365%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/storage.py 30 32 93.75%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.59%
renku/command/rollback.py 2 78.7%
renku/core/workflow/activity.py 2 93.61%
Totals Coverage Status
Change from base Build 5077776074: 0.07%
Covered Lines: 25705
Relevant Lines: 30112
💛 - Coveralls

m-alisafaee
m-alisafaee approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Panaetius Panaetius enabled auto-merge (squash) May 25, 2023 11:20
@Panaetius Panaetius merged commit 5730ce5 into develop May 25, 2023
28 checks passed
@Panaetius Panaetius deleted the fix/3440-renku-lfs-migrate-ids branch May 25, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure renku lfs migrate works as intended
3 participants
@Panaetius @coveralls @m-alisafaee