Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service): add support for using default values in template parameters #3550

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(service): add support for using default values in template parameters #3550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions renku/ui/service/controllers/templates_create_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,10 @@ def setup_template(self):
self.template_version = repository.head.commit.hexsha

# Verify missing parameters
template_parameters = {p.name for p in self.template.parameters}
template_parameters = {p.name: p for p in self.template.parameters}
provided_parameters = {p["key"]: p["value"] for p in self.ctx["parameters"]}
missing_keys = list(template_parameters - provided_parameters.keys())
missing_keys = list(template_parameters.keys() - provided_parameters.keys())
missing_keys = [k for k in missing_keys if not template_parameters[k].has_default]
if len(missing_keys) > 0:
raise UserProjectCreationError(error_message=f"the template requires a value for '${missing_keys[0]}'")

Expand Down