Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): setting non-existing config property to null #3595

Merged
merged 4 commits into from Aug 24, 2023
Merged

fix(core): setting non-existing config property to null #3595

merged 4 commits into from Aug 24, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 18, 2023

fixes #3544

/deploy #persist

@olevski olevski requested a review from a team as a code owner August 18, 2023 13:44
@olevski olevski marked this pull request as draft August 18, 2023 13:44
@olevski olevski temporarily deployed to renku-ci-rp-3595 August 18, 2023 13:45 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-3595.dev.renku.ch

@coveralls
Copy link
Collaborator

coveralls commented Aug 18, 2023 •
edited

Pull Request Test Coverage Report for Build 5956840911

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.02%) to 85.726%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 74.07%
renku/ui/service/errors.py 1 81.95%
renku/command/rollback.py 2 78.7%
renku/core/workflow/activity.py 2 93.61%
renku/ui/service/views/error_handlers.py 6 84.91%
Totals Coverage Status
Change from base Build 5953948159: -0.02%
Covered Lines: 25849
Relevant Lines: 30153
💛 - Coveralls

Panaetius
Panaetius previously approved these changes Aug 21, 2023
View reviewed changes
@olevski olevski temporarily deployed to renku-ci-rp-3595 August 21, 2023 20:35 — with GitHub Actions Inactive
@olevski olevski force-pushed the fix-3544-setting-null-more-than-once branch from 119caf0 to 5aeca28 Compare August 21, 2023 20:45
@olevski olevski temporarily deployed to renku-ci-rp-3595 August 21, 2023 20:45 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to renku-ci-rp-3595 August 22, 2023 00:56 — with GitHub Actions Inactive
@olevski olevski changed the title chore: add ui-server url in swagger fix(core): setting non-existing config property to null Aug 23, 2023
@olevski olevski marked this pull request as ready for review August 23, 2023 15:22
@olevski olevski force-pushed the fix-3544-setting-null-more-than-once branch from 057b469 to a2195db Compare August 23, 2023 15:25
@olevski olevski temporarily deployed to renku-ci-rp-3595 August 23, 2023 15:25 — with GitHub Actions Inactive
@olevski olevski deployed to renku-ci-rp-3595 August 23, 2023 21:53 — with GitHub Actions Active
@olevski olevski merged commit e0ff587 into develop Aug 24, 2023
28 of 29 checks passed
@olevski olevski deleted the fix-3544-setting-null-more-than-once branch August 24, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

@m-alisafaee m-alisafaee Awaiting requested review from m-alisafaee

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting a project setting to null more than once results in an error from renku-core
5 participants
@olevski @RenkuBot @coveralls @Panaetius @m-alisafaee