Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dataset tagging #693

Merged
merged 15 commits into from Sep 22, 2019
Merged

feat: dataset tagging #693

merged 15 commits into from Sep 22, 2019

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Sep 19, 2019

adds 3 new commands:

  • renku dataset tag <dataset> <tag> [-d <description>] [--force] creates a tag
  • renku dataset ls-tags <dataset> List all tags in a dataset
  • renku dataset rm-tags <dataset> <tags...> Remove one or more tags from a dataset

Additionally, importing a dataset tags it with the remote version.
Exporting a dataset with tags allows selecting what tag to export and temporarily checks out the repo at that tag for exporting.

The export command does not currently work for dirty directories (as that'd require stashing local changes and popping them later, which I wasn't sure was necessary), but I can add that if wanted.

Closes #566

@Panaetius Panaetius requested a review from a team as a code owner September 19, 2019 15:55
Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this. It's an amazing contribution and I'm super happy about having this. 👍

I made some minor comments which would help us merge this into the new structure, other than that it looks and works great.

renku/api/datasets.py Outdated Show resolved Hide resolved
renku/api/datasets.py Show resolved Hide resolved
renku/cli/_format/dataset_tags.py Outdated Show resolved Hide resolved
renku/cli/_format/dataset_tags.py Outdated Show resolved Hide resolved
renku/cli/_format/datasets.py Show resolved Hide resolved
renku/cli/dataset.py Outdated Show resolved Hide resolved
renku/cli/dataset.py Show resolved Hide resolved
renku/cli/dataset.py Outdated Show resolved Hide resolved
renku/models/datasets.py Show resolved Hide resolved
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested the functionality and it seems to work as promised.

renku/api/datasets.py Outdated Show resolved Hide resolved
@jsam jsam merged commit 797161f into master Sep 22, 2019
@jsam jsam deleted the 566-dataset-tagging branch September 22, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset tagging
3 participants